Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: net/url_request/test_url_fetcher_factory.h

Issue 2487073005: Remove direct usage of BrowserThreadImpl in tests (Closed)
Patch Set: The RDHImpl is actually not even necessary in ResourceSchedulerTest, removed. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/resolve_proxy_msg_helper_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/test_url_fetcher_factory.h
diff --git a/net/url_request/test_url_fetcher_factory.h b/net/url_request/test_url_fetcher_factory.h
index e1c9e9b6856c636653a35de6d597a9180eb19479..00d140357a6ed1d384fb2902d0d5bfe7f3f3d7fd 100644
--- a/net/url_request/test_url_fetcher_factory.h
+++ b/net/url_request/test_url_fetcher_factory.h
@@ -45,10 +45,9 @@ class ScopedURLFetcherFactory : public base::NonThreadSafe {
// the callback method when appropriate. In this way it's easy to mock a
// URLFetcher.
// Typical usage:
-// // TestURLFetcher requires a MessageLoop.
-// MessageLoop message_loop;
-// // And an IO thread to release URLRequestContextGetter in URLFetcher::Core.
-// BrowserThreadImpl io_thread(BrowserThread::IO, &message_loop);
+// // TestURLFetcher requires a MessageLoop and an IO thread to release
+// // URLRequestContextGetter in URLFetcher::Core.
+// TestBrowserThreadBundle thread_bundle_;
// // Create factory (it automatically sets itself as URLFetcher's factory).
// TestURLFetcherFactory factory;
// // Do something that triggers creation of a URLFetcher.
« no previous file with comments | « content/browser/resolve_proxy_msg_helper_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698