Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: content/browser/resolve_proxy_msg_helper_unittest.cc

Issue 2487073005: Remove direct usage of BrowserThreadImpl in tests (Closed)
Patch Set: The RDHImpl is actually not even necessary in ResourceSchedulerTest, removed. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/resolve_proxy_msg_helper_unittest.cc
diff --git a/content/browser/resolve_proxy_msg_helper_unittest.cc b/content/browser/resolve_proxy_msg_helper_unittest.cc
index 0281386e594da35fd28c35c8726c2386070f8798..1afc709404dbf924ab949f78ee5da3b714bcb544 100644
--- a/content/browser/resolve_proxy_msg_helper_unittest.cc
+++ b/content/browser/resolve_proxy_msg_helper_unittest.cc
@@ -7,8 +7,8 @@
#include <tuple>
#include "base/memory/ptr_util.h"
-#include "content/browser/browser_thread_impl.h"
#include "content/common/view_messages.h"
+#include "content/public/test/test_browser_thread_bundle.h"
#include "ipc/ipc_test_sink.h"
#include "net/base/net_errors.h"
#include "net/proxy/mock_proxy_resolver.h"
@@ -66,8 +66,7 @@ class ResolveProxyMsgHelperTest : public testing::Test, public IPC::Listener {
new net::ProxyService(base::WrapUnique(new MockProxyConfigService),
base::WrapUnique(resolver_factory_),
NULL)),
- helper_(new TestResolveProxyMsgHelper(service_.get(), this)),
- io_thread_(BrowserThread::IO, &message_loop_) {
+ helper_(new TestResolveProxyMsgHelper(service_.get(), this)) {
test_sink_.AddFilter(this);
}
@@ -102,8 +101,7 @@ class ResolveProxyMsgHelperTest : public testing::Test, public IPC::Listener {
return true;
}
- base::MessageLoopForIO message_loop_;
- BrowserThreadImpl io_thread_;
+ TestBrowserThreadBundle thread_bundle_;
IPC::TestSink test_sink_;
};
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | net/url_request/test_url_fetcher_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698