Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Issue 2487073004: Change the default budget expiration window to 4 days from 10 days. (Closed)

Created:
4 years, 1 month ago by harkness
Modified:
4 years, 1 month ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change the default budget expiration window to 4 days from 10 days. The budget system uses a sliding window which is currently 10 days. That window is used to set the expiration time for new budget and also to control how much budget an origin can "save up" for future use. Based on the UMA data on the updated Site Engagement algorithm in M55, we can narrow that window while still giving sites an incentive not to overspend budget. This CL reduces the window from 10 days to 4 days. It also updates the relevant tests, in a way that will be more flexible going forward. BUG=617971 Committed: https://crrev.com/6d52fba2161db44cb252088ec54ea0ae3b059072 Cr-Commit-Position: refs/heads/master@{#431971}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M chrome/browser/budget_service/budget_database.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/budget_service/budget_database_unittest.cc View 1 3 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
harkness
4 years, 1 month ago (2016-11-09 13:25:41 UTC) #2
Peter Beverloo
lgtm
4 years, 1 month ago (2016-11-14 22:34:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487073004/20001
4 years, 1 month ago (2016-11-14 22:37:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-14 23:35:45 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-14 23:43:41 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d52fba2161db44cb252088ec54ea0ae3b059072
Cr-Commit-Position: refs/heads/master@{#431971}

Powered by Google App Engine
This is Rietveld 408576698