Change the default budget expiration window to 4 days from 10 days.

chrome/browser/budget_service/budget_database_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/budget_service/budget_database.h"
 
 #include <vector>
 
 #include "base/run_loop.h"
 #include "base/test/histogram_tester.h"
 #include "base/test/simple_test_clock.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/budget_service/budget.pb.h"
 #include "chrome/browser/engagement/site_engagement_service.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/leveldb_proto/proto_database.h"
 #include "components/leveldb_proto/proto_database_impl.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "mojo/public/cpp/bindings/array.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "url/gurl.h"
 #include "url/origin.h"
 
 namespace {
 
-const double kDefaultExpirationInHours = 240;
+const double kDefaultExpirationInHours = 96;
 const double kDefaultEngagement = 30.0;
 
 const char kTestOrigin[] = "https://example.com";
 
 }  // namespace
 
 class BudgetDatabaseTest : public ::testing::Test {
  public:
   BudgetDatabaseTest()
       : success_(false),
@@ skipping 198 matching lines @@
   ASSERT_EQ(3U, prediction_.size());
   ASSERT_EQ(budget, prediction_[0]->budget_at);
 }
 
 TEST_F(BudgetDatabaseTest, CheckBackgroundBudgetHistogram) {
   base::SimpleTestClock* clock = SetClockForTesting();
 
   // Set the default site engagement.
   SetSiteEngagementScore(kDefaultEngagement);
 
-  // Initialize the budget with some interesting chunks: 30 budget, 3 budget,
-  // 0 budget, and then after the first two expire, another 30 budget.
+  // Initialize the budget with some interesting chunks: 30 budget (full
+  // engagement), 15 budget (half of the engagement), 0 budget (less than an
+  // hour), and then after the first two expire, another 30 budget.
   GetBudgetDetails();
-  clock->Advance(base::TimeDelta::FromDays(2));
+  clock->Advance(base::TimeDelta::FromHours(kDefaultExpirationInHours / 2));
   GetBudgetDetails();
   clock->Advance(base::TimeDelta::FromMinutes(59));
   GetBudgetDetails();
-  clock->Advance(base::TimeDelta::FromDays(11));
+  clock->Advance(base::TimeDelta::FromHours(kDefaultExpirationInHours + 1));
   GetBudgetDetails();
 
   // The BackgroundBudget UMA is recorded when budget is added to the origin.
   // This can happen a maximum of once per hour so there should be two entries.
   std::vector<base::Bucket> buckets =
       GetHistogramTester()->GetAllSamples("PushMessaging.BackgroundBudget");
   ASSERT_EQ(2U, buckets.size());
-  // First bucket is for 30 budget, which should have 2 entries.
-  EXPECT_EQ(30, buckets[0].min);
+  // First bucket is for full engagement, which should have 2 entries.
+  EXPECT_EQ(kDefaultEngagement, buckets[0].min);
   EXPECT_EQ(2, buckets[0].count);
-  // Second bucket is for 36 budget, which should have 1 entry.
-  EXPECT_EQ(36, buckets[1].min);
+  // Second bucket is for 1.5 * engagement, which should have 1 entry.
+  EXPECT_EQ(kDefaultEngagement * 1.5, buckets[1].min);
   EXPECT_EQ(1, buckets[1].count);
 }
 
 TEST_F(BudgetDatabaseTest, CheckEngagementHistograms) {
   base::SimpleTestClock* clock = SetClockForTesting();
 
   // Set the engagement to twice the cost of an action.
   double cost = 2;
   double engagement = cost * 2;
   SetSiteEngagementScore(engagement);
@@ skipping 29 matching lines @@
 
   std::vector<base::Bucket> low_budget_buckets =
       GetHistogramTester()->GetAllSamples(
           "PushMessaging.SESForLowBudgetOrigin");
   ASSERT_EQ(2U, low_budget_buckets.size());
   EXPECT_EQ(engagement, low_budget_buckets[0].min);
   EXPECT_EQ(1, low_budget_buckets[0].count);
   EXPECT_EQ(engagement * 2, low_budget_buckets[1].min);
   EXPECT_EQ(1, low_budget_buckets[1].count);
 }