Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2487033002: Use EXPECT_DOUBLE_EQ for doubles in NotificationPromoTest. (Closed)

Created:
4 years, 1 month ago by gchatz
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use EXPECT_DOUBLE_EQ for doubles in NotificationPromoTest. Use EXPECT_DOUBLE_EQ when evaluating doubles in NotificationPromoTest instead of EXPECT_EQ, as EXPECT_EQ was causing double rounding flakes. BUG=662670 Committed: https://crrev.com/0e0fffa9c011d3a3125528ffddf146403d524dab Cr-Commit-Position: refs/heads/master@{#431308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ios/chrome/browser/notification_promo_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
gchatz
4 years, 1 month ago (2016-11-08 23:43:26 UTC) #3
gchatz
friendly ping
4 years, 1 month ago (2016-11-10 18:43:38 UTC) #4
rohitrao (ping after 24h)
LGTM, but why are we storing times as doubles and not int32/int64?
4 years, 1 month ago (2016-11-10 18:45:25 UTC) #5
gchatz
On 2016/11/10 18:45:25, rohitrao wrote: > LGTM, but why are we storing times as doubles ...
4 years, 1 month ago (2016-11-10 18:54:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2487033002/1
4 years, 1 month ago (2016-11-10 18:54:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 19:04:46 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 19:10:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e0fffa9c011d3a3125528ffddf146403d524dab
Cr-Commit-Position: refs/heads/master@{#431308}

Powered by Google App Engine
This is Rietveld 408576698