Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Unified Diff: ios/chrome/browser/notification_promo_unittest.cc

Issue 2487033002: Use EXPECT_DOUBLE_EQ for doubles in NotificationPromoTest. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/notification_promo_unittest.cc
diff --git a/ios/chrome/browser/notification_promo_unittest.cc b/ios/chrome/browser/notification_promo_unittest.cc
index d27c78a3b1540dcc8513ba6743467a28538154a5..830d9c5f65a02412b9a60cd4a6e142bd19bb47d9 100644
--- a/ios/chrome/browser/notification_promo_unittest.cc
+++ b/ios/chrome/browser/notification_promo_unittest.cc
@@ -147,8 +147,8 @@ class NotificationPromoTest : public testing::Test {
// Check values.
EXPECT_EQ(notification_promo_.promo_text_, promo_text_);
- EXPECT_EQ(notification_promo_.start_, start_);
- EXPECT_EQ(notification_promo_.end_, end_);
+ EXPECT_DOUBLE_EQ(notification_promo_.start_, start_);
+ EXPECT_DOUBLE_EQ(notification_promo_.end_, end_);
EXPECT_EQ(notification_promo_.promo_id_, promo_id_);
EXPECT_EQ(notification_promo_.max_views_, max_views_);
@@ -275,7 +275,7 @@ class NotificationPromoTest : public testing::Test {
// Tests that the first view time is recorded properly in prefs when the
// first view occurs.
void TestFirstViewTimeRecorded() {
- EXPECT_EQ(0, notification_promo_.first_view_time_);
+ EXPECT_DOUBLE_EQ(0, notification_promo_.first_view_time_);
notification_promo_.HandleViewed();
NotificationPromo temp_promo(&local_state_);
@@ -321,7 +321,7 @@ class NotificationPromoTest : public testing::Test {
// Initialize promo and verify that its instance variables match the data
// saved in the old structure.
promo.InitFromPrefs(promo_type_);
- EXPECT_EQ(first_view_time, promo.first_view_time_);
+ EXPECT_DOUBLE_EQ(first_view_time, promo.first_view_time_);
EXPECT_EQ(views, promo.views_);
EXPECT_EQ(closed, promo.closed_);
EXPECT_FALSE(promo.CanShow());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698