Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2486973004: Update cross-context options encoding to account for patchPlatform. (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update cross-context options encoding to account for patchPlatform. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/1dfa5685cef0d49b77188905394791cc43becacc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -49 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 3 chunks +10 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 5 chunks +64 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/generated/package.dart View 2 chunks +7 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 1 month ago (2016-11-09 13:57:16 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-09 15:04:45 UTC) #3
Paul Berry
4 years, 1 month ago (2016-11-09 17:12:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1dfa5685cef0d49b77188905394791cc43becacc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698