Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: pkg/analyzer/lib/src/dart/analysis/driver.dart

Issue 2486973004: Update cross-context options encoding to account for patchPlatform. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/dart/analysis/driver.dart
diff --git a/pkg/analyzer/lib/src/dart/analysis/driver.dart b/pkg/analyzer/lib/src/dart/analysis/driver.dart
index c8dfe3ca380e36d9e00592d8966d1b968dfbb6e6..013b88378d308b83b7cfd66abf3f4f97a0334509 100644
--- a/pkg/analyzer/lib/src/dart/analysis/driver.dart
+++ b/pkg/analyzer/lib/src/dart/analysis/driver.dart
@@ -66,7 +66,7 @@ class AnalysisDriver {
/**
* The version of data format, should be incremented on every format change.
*/
- static const int DATA_VERSION = 2;
+ static const int DATA_VERSION = 3;
/**
* The name of the driver, e.g. the name of the folder.
@@ -116,7 +116,8 @@ class AnalysisDriver {
/**
* The salt to mix into all hashes used as keys for serialized data.
*/
- final Uint32List _salt = new Uint32List(2);
+ final Uint32List _salt =
+ new Uint32List(1 + AnalysisOptions.crossContextOptionsLength);
/**
* The current file system state.
@@ -597,7 +598,13 @@ class AnalysisDriver {
*/
void _fillSalt() {
_salt[0] = DATA_VERSION;
- _salt[1] = _analysisOptions.encodeCrossContextOptions();
+ List<int> crossContextOptions =
+ _analysisOptions.encodeCrossContextOptions();
+ assert(crossContextOptions.length ==
+ AnalysisOptions.crossContextOptionsLength);
+ for (int i = 0; i < crossContextOptions.length; i++) {
+ _salt[i + 1] = crossContextOptions[i];
+ }
}
/**
« no previous file with comments | « pkg/analysis_server/lib/src/status/get_handler.dart ('k') | pkg/analyzer/lib/src/generated/engine.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698