Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2486703002: Change IR encoding of redirecting factory invocations. (Closed)

Created:
4 years, 1 month ago by Johnni Winther
Modified:
4 years, 1 month ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change IR encoding of redirecting factory invocations. - redirecting factory constructors are not included in the program - invocations of redirecting factory constructor point to the effective target R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/26f61fe1d4b39a8f9c8cdfbcb5aa014b82ed62f1

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix impact_test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M pkg/compiler/lib/src/kernel/kernel.dart View 2 chunks +10 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +2 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/visitor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 1 month ago (2016-11-08 09:15:22 UTC) #2
Harry Terkelsen
lgtm
4 years, 1 month ago (2016-11-08 18:09:13 UTC) #3
Johnni Winther
4 years, 1 month ago (2016-11-09 15:22:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
26f61fe1d4b39a8f9c8cdfbcb5aa014b82ed62f1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698