Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: pkg/compiler/lib/src/kernel/kernel_visitor.dart

Issue 2486703002: Change IR encoding of redirecting factory invocations. (Closed)
Patch Set: Fix impact_test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/kernel_visitor.dart
diff --git a/pkg/compiler/lib/src/kernel/kernel_visitor.dart b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
index e6ed1e475a1b2cc5d6d200fa58713f8de56e429d..39a1a8d82024747a9ee131a5496efe576781eb37 100644
--- a/pkg/compiler/lib/src/kernel/kernel_visitor.dart
+++ b/pkg/compiler/lib/src/kernel/kernel_visitor.dart
@@ -1158,13 +1158,8 @@ class KernelVisitor extends Object
ir.Expression buildConstructorInvoke(NewExpression node, {bool isConst}) {
ConstructorElement constructor = elements[node.send];
- ConstructorTarget target;
- if (isConst) {
- target =
- kernel.computeEffectiveTarget(constructor, elements.getType(node));
- } else {
- target = new ConstructorTarget(constructor, elements.getType(node));
- }
+ ConstructorTarget target =
+ kernel.computeEffectiveTarget(constructor, elements.getType(node));
NodeList arguments = node.send.argumentsNode;
if (kernel.isSyntheticError(target.element)) {
return new ir.MethodInvocation(new ir.InvalidExpression(),
« no previous file with comments | « pkg/compiler/lib/src/kernel/kernel.dart ('k') | tests/compiler/dart2js/kernel/impact_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698