Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2486463005: [Reland] DevTools: Make WorkerThreadDebugger available for Worklets (Closed)

Created:
4 years, 1 month ago by nhiroki
Modified:
4 years, 1 month ago
Reviewers:
haraken, dgozman
CC:
chromium-reviews, shans, tzik, apavlov+blink_chromium.org, kinuko+worker_chromium.org, jsbell+serviceworker_chromium.org, caseq+blink_chromium.org, hongchan, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, blink-reviews, falken+watch_chromium.org, blink-worker-reviews_chromium.org, Eric Willigers, rjwright, lushnikov+blink_chromium.org, Raymond Toy, darktears, haraken, michaeln, shimazu+serviceworker_chromium.org, blink-reviews-animation_chromium.org, serviceworker-reviews, shimazu+worker_chromium.org, pfeldman+blink_chromium.org, kinuko+serviceworker, horo+watch_chromium.org, kozyatinskiy+blink_chromium.org, ikilpatrick, falken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Reland] DevTools: Make WorkerThreadDebugger available for Worklets Original CL: https://codereview.chromium.org/2456733002/ The original CL was reverted because there was a memory leak. This leak was fixed by https://codereview.chromium.org/2482393002/ In addition to that, this reland CL changes layout tests added by the original CL because they depended on leaked Document context. After the leak is fixed, the context can be destroyed earlier than console messages from Worklets are printed. New layout tests wait until console messages are printed. <Original Description> DevTools is now disabled on Worklets because worker's debugger infrastructure(*) cannot host multiple worklet execution contexts on a single thread. (*) Worklet has been implemented on the worker infrastructure. To support it, this CL does following things: - This expands 1:1 relationship between WorkerThreadDebugger and WorkerThread to 1:M relationship. The debugger has a ID-WorkerThread map to manage multiple WorkerThreads. WorkerThread is added when worklet context is created and removed when the context is destroyed. - This decouples lifetime of WorkerThreadDebugger from lifetime of worklet context. Before this CL, the debugger has the same lifetime of the context. This prevents the debugger from hosting multiple contexts. After this CL, the debugger has the same lifetime of WorkerBackingThread, and attaches to worklet context when it's created. DesignDoc: https://docs.google.com/document/d/1v0dNB6jWMe7w6OeK-Vlnn-Q4qW7KI4m97LGnMefUx1k/edit BUG=646559 Committed: https://crrev.com/0bdb1f395432064cc19799facf055317a12ec6ce Cr-Commit-Position: refs/heads/master@{#431198}

Patch Set 1 : Original CL #

Patch Set 2 : Change layout tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -77 lines) Patch
A third_party/WebKit/LayoutTests/inspector/console/console-on-animation-worklet.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-on-animation-worklet-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet.html View 1 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-on-paint-worklet-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-worklet-script.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt View 1 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.h View 2 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp View 6 chunks +62 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/ThreadedWorkletGlobalScope.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.h View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 5 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 26 (16 generated)
nhiroki
Hi dgozman@, can you take another look at this? I changed layout tests from the ...
4 years, 1 month ago (2016-11-10 02:25:51 UTC) #9
dgozman
lgtm
4 years, 1 month ago (2016-11-10 06:22:12 UTC) #12
haraken
LGTM
4 years, 1 month ago (2016-11-10 06:41:29 UTC) #15
nhiroki
+haraken@ for WorkerOrWorkletScriptController.cpp. Let me use TBR because there are no changes in C++ files ...
4 years, 1 month ago (2016-11-10 06:41:48 UTC) #16
nhiroki
On 2016/11/10 06:41:29, haraken wrote: > LGTM Thank you! You're sooooooooooooo fast :D
4 years, 1 month ago (2016-11-10 06:42:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486463005/20001
4 years, 1 month ago (2016-11-10 06:47:35 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-10 06:52:13 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0bdb1f395432064cc19799facf055317a12ec6ce Cr-Commit-Position: refs/heads/master@{#431198}
4 years, 1 month ago (2016-11-10 06:54:42 UTC) #24
hiroshige
On 2016/11/10 06:54:42, commit-bot: I haz the power wrote: > Patchset 2 (id:??) landed as ...
4 years, 1 month ago (2016-11-11 08:23:21 UTC) #25
nhiroki
4 years, 1 month ago (2016-11-11 10:19:30 UTC) #26
Message was sent while issue was closed.
On 2016/11/11 08:23:21, hiroshige wrote:
> On 2016/11/10 06:54:42, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/0bdb1f395432064cc19799facf055317a12ec6ce
> > Cr-Commit-Position: refs/heads/master@{#431198}
> 
> The test inspector/console/console-on-animation-worklet.html added by this CL
is
> quite flaky:
>
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=in...

Thank you for reporting this. I'll update TestExpectations...

Powered by Google App Engine
This is Rietveld 408576698