Chromium Code Reviews

Unified Diff: extensions/common/constants.h

Issue 2486453002: Fix Extensions.AppLaunchSource off-by-one error (Closed)
Patch Set: fix enum in xml Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « extensions/common/api/app_runtime.idl ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/constants.h
diff --git a/extensions/common/constants.h b/extensions/common/constants.h
index b6b1bca29a90295e28e38fb4d68f1cceff68543f..e451071b93eb232f4755998636205a9066b25765 100644
--- a/extensions/common/constants.h
+++ b/extensions/common/constants.h
@@ -117,10 +117,14 @@ extern const uint8_t kWebstoreSignaturesPublicKey[];
extern const int kWebstoreSignaturesPublicKeySize;
// Enumeration of possible app launch sources.
+// This should be kept in sync with LaunchSource in
+// extensions/common/api/app_runtime.idl, and GetLaunchSourceEnum() in
+// extensions/browser/api/app_runtime/app_runtime_api.cc.
// Note the enumeration is used in UMA histogram so entries
// should not be re-ordered or removed.
enum AppLaunchSource {
- SOURCE_UNTRACKED = 0,
+ SOURCE_NONE,
+ SOURCE_UNTRACKED,
SOURCE_APP_LAUNCHER,
SOURCE_NEW_TAB_PAGE,
SOURCE_RELOAD,
@@ -140,7 +144,6 @@ enum AppLaunchSource {
SOURCE_CHROME_INTERNAL,
SOURCE_TEST,
SOURCE_INSTALLED_NOTIFICATION,
-
NUM_APP_LAUNCH_SOURCES
};
« no previous file with comments | « extensions/common/api/app_runtime.idl ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine