Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: extensions/common/api/app_runtime.idl

Issue 2486453002: Fix Extensions.AppLaunchSource off-by-one error (Closed)
Patch Set: fix enum in xml Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/api/app_runtime/app_runtime_api.cc ('k') | extensions/common/constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/api/app_runtime.idl
diff --git a/extensions/common/api/app_runtime.idl b/extensions/common/api/app_runtime.idl
index 0e251ff5b94c011577fe24bfae20d397be0900da..3ff0219752aae1e7e5f8f9978b18d135decc1da9 100644
--- a/extensions/common/api/app_runtime.idl
+++ b/extensions/common/api/app_runtime.idl
@@ -16,6 +16,11 @@ namespace app.runtime {
};
// Enumeration of app launch sources.
+ // This should be kept in sync with AppLaunchSource in
+ // extensions/common/constants.h, and GetLaunchSourceEnum() in
+ // extensions/browser/api/app_runtime/app_runtime_api.cc.
+ // Note the enumeration is used in UMA histogram so entries
+ // should not be re-ordered or removed.
enum LaunchSource {
untracked,
app_launcher,
« no previous file with comments | « extensions/browser/api/app_runtime/app_runtime_api.cc ('k') | extensions/common/constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698