Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2411773003: Dirty lineboxes when adding a float to an empty inline (Closed)

Created:
4 years, 2 months ago by rhogan
Modified:
4 years, 2 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dirty lineboxes when adding a float to an empty inline BUG=648342 Committed: https://crrev.com/7937b7b2c7272149da614489b0147efed3ac9ace Cr-Commit-Position: refs/heads/master@{#424808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks.html View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-expected.html View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBoxList.cpp View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rhogan
4 years, 2 months ago (2016-10-12 18:46:25 UTC) #6
eae
LGTM
4 years, 2 months ago (2016-10-12 18:51:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2411773003/1
4 years, 2 months ago (2016-10-12 18:51:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 19:00:08 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 19:02:26 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7937b7b2c7272149da614489b0147efed3ac9ace
Cr-Commit-Position: refs/heads/master@{#424808}

Powered by Google App Engine
This is Rietveld 408576698