Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: net/android/network_library_unittest.cc

Issue 2486393004: Expose API to detect when captive portal probe was blocked on Android (Closed)
Patch Set: Move back to network library from NCN Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/android/network_library_unittest.cc
diff --git a/net/android/network_library_unittest.cc b/net/android/network_library_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..0cfec29394eebe1e7083485a7ef30d445a15fe12
--- /dev/null
+++ b/net/android/network_library_unittest.cc
@@ -0,0 +1,23 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/android/network_library.h"
+
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace net {
+
+namespace android {
+
+namespace {
pauljensen 2016/11/24 00:11:19 Remove the anonymous namespace
tbansal1 2016/11/24 00:43:09 Done. Is this a //net specific guideline? A cursor
pauljensen 2016/11/24 01:36:41 I don't feel strongly. There are pros and cons to
+
+TEST(NetworkLibraryTest, CaptivePortal) {
+ EXPECT_FALSE(android::GetIsCaptivePortal());
+}
+
+} // namespace
+
+} // namespace android
+
+} // namespace net

Powered by Google App Engine
This is Rietveld 408576698