net/android/network_library_unittest.cc - Issue 2486393004: Expose API to detect when captive portal probe was blocked on Android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/android/network_library_unittest.cc

Issue 2486393004: Expose API to detect when captive portal probe was blocked on Android (Closed)

Patch Set: Move back to network library from NCN Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "net/android/network_library.h"

	6

	7 #include "testing/gtest/include/gtest/gtest.h"

	8

	9 namespace net {

	10

	11 namespace android {

	12

	13 namespace {
	pauljensen 2016/11/24 00:11:19 Remove the anonymous namespace Remove the anonymous namespace tbansal1 2016/11/24 00:43:09 Done. Is this a //net specific guideline? A cursor Show quoted text On 2016/11/24 00:11:19, pauljensen wrote: > Remove the anonymous namespace Done. Is this a //net specific guideline? A cursory search on chromium-dev suggests that it is okay (if not preferable) to put tests in anonymous namespaces. https://groups.google.com/a/chromium.org/d/msg/chromium-dev/MwPIo2BnVhM/wvZxl... https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pKY2G4GHcu0/398sq... pauljensen 2016/11/24 01:36:41 I don't feel strongly. There are pros and cons to Show quoted text On 2016/11/24 00:43:09, tbansal1 wrote: > On 2016/11/24 00:11:19, pauljensen wrote: > > Remove the anonymous namespace > > Done. Is this a //net specific guideline? > A cursory search on chromium-dev suggests that it is okay (if not preferable) to > put tests in anonymous namespaces. > > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/MwPIo2BnVhM/wvZxl... > > https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pKY2G4GHcu0/398sq... I don't feel strongly. There are pros and cons to both.
	14

	15 TEST(NetworkLibraryTest, CaptivePortal) {

	16 EXPECT_FALSE(android::GetIsCaptivePortal());

	17 }

	18

	19 } // namespace

	20

	21 } // namespace android

	22

	23 } // namespace net

OLD	NEW

« net/android/network_library.h ('K') | « net/android/network_library.cc ('k') | net/net.gypi » ('j') | no next file with comments »