Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2486313002: Correct net::EmbeddedTestServer usage in some SSL related tests. (Closed)

Created:
4 years, 1 month ago by martijnc
Modified:
4 years, 1 month ago
Reviewers:
palmer
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct net::EmbeddedTestServer usage in some SSL related tests. Adding request handlers to the EmbeddedTestServer after it has started isn't thread safe. This CL updates some tests so that the EmbeddedTestServer's IO thread is started after all handlers are added. BUG=546060 Committed: https://crrev.com/839218498ade5aae2571b58325beef424905ba55 Cr-Commit-Position: refs/heads/master@{#431347}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/ssl/ssl_error_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/ssl_errors/error_classification_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
martijnc
Hi, can you review this patch? Thanks!
4 years, 1 month ago (2016-11-10 13:29:29 UTC) #2
palmer
lgtm
4 years, 1 month ago (2016-11-10 20:26:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486313002/1
4 years, 1 month ago (2016-11-10 20:27:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 20:59:46 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 21:02:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/839218498ade5aae2571b58325beef424905ba55
Cr-Commit-Position: refs/heads/master@{#431347}

Powered by Google App Engine
This is Rietveld 408576698