Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: components/ssl_errors/error_classification_unittest.cc

Issue 2486313002: Correct net::EmbeddedTestServer usage in some SSL related tests. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ssl/ssl_error_handler_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ssl_errors/error_classification_unittest.cc
diff --git a/components/ssl_errors/error_classification_unittest.cc b/components/ssl_errors/error_classification_unittest.cc
index efd7cb3dcf62ea0330c016634c1c1d4a9eee28ff..1e0990faa7dd6702a11a93ed636abf7f5bc0139d 100644
--- a/components/ssl_errors/error_classification_unittest.cc
+++ b/components/ssl_errors/error_classification_unittest.cc
@@ -338,7 +338,7 @@ TEST_F(SSLErrorClassificationTest, NetworkClockStateHistogram) {
EXPECT_TRUE(io_thread.StartWithOptions(thread_options));
net::EmbeddedTestServer test_server;
- ASSERT_TRUE(test_server.Start());
+ ASSERT_TRUE(test_server.InitializeAndListen());
base::HistogramTester histograms;
histograms.ExpectTotalCount(kNetworkTimeHistogram, 0);
@@ -371,6 +371,7 @@ TEST_F(SSLErrorClassificationTest, NetworkClockStateHistogram) {
// First sync attempt is pending.
test_server.RegisterRequestHandler(base::Bind(&NetworkErrorResponseHandler));
+ test_server.StartAcceptingConnections();
EXPECT_TRUE(network_time_tracker.QueryTimeServiceForTesting());
EXPECT_EQ(
ssl_errors::ClockState::CLOCK_STATE_UNKNOWN,
« no previous file with comments | « chrome/browser/ssl/ssl_error_handler_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698