VM: Support bootstrapping core libraries from Kernel binaries instead of source.

runtime/vm/method_recognizer.h

Index: runtime/vm/method_recognizer.h
diff --git a/runtime/vm/method_recognizer.h b/runtime/vm/method_recognizer.h
index ed079f6647a9ee9fb3f1c37070469b4812e674f7..dbe689995bc4e21ebd3a994566e06ae7463f315d 100644
--- a/runtime/vm/method_recognizer.h
+++ b/runtime/vm/method_recognizer.h
@@ -518,19 +518,15 @@ class MethodRecognizer : public AllStatic {
   static intptr_t ResultCid(const Function& function);
   static intptr_t MethodKindToReceiverCid(Kind kind);
   static const char* KindToCString(Kind kind);
-#if defined(DART_NO_SNAPSHOT)
   static void InitializeState();
-#endif  // defined(DART_NO_SNAPSHOT).
 };
 
 
-#if defined(DART_NO_SNAPSHOT)

[Florian Schneider, 2016/11/11 14:00:12]

Why remove this #ifdef?

Or more general: Please make sure that binary size of "dart" and
"dart_precompiled_runtime" are not negatively affected by this CL. Only
dart_bootstrap should be affected at all.

[Vyacheslav Egorov (Google), 2016/11/11 15:29:47]

It is removed because now even if you run with snapshot you still has the mode
where you bootstrap core libraries from Kernel instead of snapshot. 

I will check this up. (Maybe we need a test that checks this up automatically?)

[Florian Schneider, 2016/11/11 15:54:25]

My comments applies to all occurrences of DART_NO_SNAPSHOT. Basically, Why
should starting from a snapshot require bootstrapping? Starting from a snapshot
should work the same way in both scenarios. 

 #define CHECK_FINGERPRINT2(f, p0, p1, fp)                                      \
   ASSERT(f.CheckSourceFingerprint(#p0 ", " #p1, fp))
 
 #define CHECK_FINGERPRINT3(f, p0, p1, p2, fp)                                  \
   ASSERT(f.CheckSourceFingerprint(#p0 ", " #p1 ", " #p2, fp))
-#endif  // defined(DART_NO_SNAPSHOT).
 
 
 // clang-format off