VM: Support bootstrapping core libraries from Kernel binaries instead of source.

runtime/vm/method_recognizer.h

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef RUNTIME_VM_METHOD_RECOGNIZER_H_
 #define RUNTIME_VM_METHOD_RECOGNIZER_H_
 
 #include "vm/allocation.h"
 
 namespace dart {
@@ skipping 500 matching lines @@
 #undef DEFINE_ENUM_LIST
         kNumRecognizedMethods
   };
 
   static Kind RecognizeKind(const Function& function);
   static bool AlwaysInline(const Function& function);
   static bool PolymorphicTarget(const Function& function);
   static intptr_t ResultCid(const Function& function);
   static intptr_t MethodKindToReceiverCid(Kind kind);
   static const char* KindToCString(Kind kind);
-#if defined(DART_NO_SNAPSHOT)
   static void InitializeState();
-#endif  // defined(DART_NO_SNAPSHOT).
 };
 
 
-#if defined(DART_NO_SNAPSHOT)

[Florian Schneider, 2016/11/11 14:00:12]

Why remove this #ifdef?

Or more general: Please make sure that binary size of "dart" and
"dart_precompiled_runtime" are not negatively affected by this CL. Only
dart_bootstrap should be affected at all.

[Vyacheslav Egorov (Google), 2016/11/11 15:29:47]

It is removed because now even if you run with snapshot you still has the mode
where you bootstrap core libraries from Kernel instead of snapshot. 

I will check this up. (Maybe we need a test that checks this up automatically?)

[Florian Schneider, 2016/11/11 15:54:25]

My comments applies to all occurrences of DART_NO_SNAPSHOT. Basically, Why
should starting from a snapshot require bootstrapping? Starting from a snapshot
should work the same way in both scenarios. 

 #define CHECK_FINGERPRINT2(f, p0, p1, fp)                                      \
   ASSERT(f.CheckSourceFingerprint(#p0 ", " #p1, fp))
 
 #define CHECK_FINGERPRINT3(f, p0, p1, p2, fp)                                  \
   ASSERT(f.CheckSourceFingerprint(#p0 ", " #p1 ", " #p2, fp))
-#endif  // defined(DART_NO_SNAPSHOT).
 
 
 // clang-format off
 // List of recognized list factories:
 // (factory-name-symbol, result-cid, fingerprint).
 #define RECOGNIZED_LIST_FACTORY_LIST(V)                                        \
   V(_ListFactory, kArrayCid, 0x63078b15)                                       \
   V(_GrowableListWithData, kGrowableObjectArrayCid, 0x25a786de)                \
   V(_GrowableListFactory, kGrowableObjectArrayCid, 0x4f4d4790)                 \
   V(_Int8ArrayFactory, kTypedDataInt8ArrayCid, 0x2e7749e3)                     \
@@ skipping 14 matching lines @@
 // Class that recognizes factories and returns corresponding result cid.
 class FactoryRecognizer : public AllStatic {
  public:
   // Return kDynamicCid if factory is not recognized.
   static intptr_t ResultCid(const Function& factory);
 };
 
 }  // namespace dart
 
 #endif  // RUNTIME_VM_METHOD_RECOGNIZER_H_