Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: runtime/vm/kernel_to_il.h

Issue 2485993002: VM: Support bootstrapping core libraries from Kernel binaries instead of source. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/kernel_to_il.h
diff --git a/runtime/vm/kernel_to_il.h b/runtime/vm/kernel_to_il.h
index 50014516babf72684bfd9d747045d1341a422c2b..8edcfb392ff64f33acb480871f09e4dd4ae51490 100644
--- a/runtime/vm/kernel_to_il.h
+++ b/runtime/vm/kernel_to_il.h
@@ -202,11 +202,6 @@ class TranslationHelper {
Heap::Space allocation_space() { return allocation_space_; }
- // Set whether unfinalized classes should be finalized. The base class
- // implementation used at flow graph construction time looks up classes in the
- // VM's heap, all of which should already be finalized.
- virtual void SetFinalize(bool finalize) {}
-
RawInstance* Canonicalize(const Instance& instance);
const dart::String& DartString(const char* content) {
@@ -241,6 +236,8 @@ class TranslationHelper {
virtual RawLibrary* LookupLibraryByKernelLibrary(Library* library);
virtual RawClass* LookupClassByKernelClass(Class* klass);
+ RawUnresolvedClass* ToUnresolvedClass(Class* klass);
+
RawField* LookupFieldByKernelField(Field* field);
RawFunction* LookupStaticMethodByKernelProcedure(Procedure* procedure);
RawFunction* LookupConstructorByKernelConstructor(Constructor* constructor);
@@ -282,7 +279,7 @@ class DartTypeTranslator : public DartTypeVisitor {
public:
DartTypeTranslator(TranslationHelper* helper,
ActiveClass* active_class,
- bool finalize = true)
+ bool finalize = false)
: translation_helper_(*helper),
active_class_(active_class),
zone_(helper->zone()),
@@ -501,7 +498,9 @@ class ScopeBuilder : public RecursiveVisitor {
node_(node),
zone_(Thread::Current()->zone()),
translation_helper_(Thread::Current(), zone_, Isolate::Current()),
- type_translator_(&translation_helper_, &active_class_),
+ type_translator_(&translation_helper_,
+ &active_class_,
+ /*finalize=*/ true),
current_function_scope_(NULL),
scope_(NULL),
depth_(0),

Powered by Google App Engine
This is Rietveld 408576698