[chromecast] Merge ChromecastBrowserTestHelper into ChromecastBrowserTest

[chromecast] Merge ChromecastBrowserTestHelper into ChromecastBrowserTest.

BUG=663067
TEST=cast_shell_browsertests

Committed: https://crrev.com/33c0d5d78594fa996cf23b3b608adacdc2a183f9
Cr-Commit-Position: refs/heads/master@{#430724}

[alokp, 2016-11-08 05:27:13]

alokp@chromium.org changed reviewers:
+ halliwell@chromium.org

[alokp, 2016-11-08 05:27:25]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 05:27:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alokp, 2016-11-08 05:34:18]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 05:34:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 05:56:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 05:56:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alokp, 2016-11-08 13:53:24]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 13:53:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[halliwell, 2016-11-08 14:13:52]

On 2016/11/08 05:27:14, alokp wrote:

why do we need helper class at all?  Can we just fold this back into
ChromecastBrowserTest now?

[alokp, 2016-11-08 14:28:29]

On 2016/11/08 14:13:52, halliwell wrote:
> On 2016/11/08 05:27:14, alokp wrote:
> 
> why do we need helper class at all?  Can we just fold this back into
> ChromecastBrowserTest now?

Agreed. Done.

[alokp, 2016-11-08 14:29:58]

The CQ bit was checked by alokp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 14:30:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[halliwell, 2016-11-08 14:47:26]

On 2016/11/08 14:28:29, alokp wrote:
> On 2016/11/08 14:13:52, halliwell wrote:
> > On 2016/11/08 05:27:14, alokp wrote:
> > 
> > why do we need helper class at all?  Can we just fold this back into
> > ChromecastBrowserTest now?
> 
> Agreed. Done.

lgtm

[commit-bot: I haz the power, 2016-11-08 14:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 14:57:37]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alokp, 2016-11-08 18:55:24]

Description was changed from

==========
[chromecast] Make ChromecastBrowserTestHelper concrete class.

BUG=663067
TEST=cast_shell_browsertests
==========

to

==========
[chromecast] Merge ChromecastBrowserTestHelper into ChromecastBrowserTest.

BUG=663067
TEST=cast_shell_browsertests
==========

[alokp, 2016-11-08 19:02:44]

alokp@chromium.org changed reviewers:
+ derekjchow@chromium.org

[alokp, 2016-11-08 19:02:44]

Derek: Can you look at media blocker test. Thanks!

https://codereview.chromium.org/2485843002/diff/100001/chromecast/browser/tes...
File chromecast/browser/test/chromecast_browser_test.cc (left):

https://codereview.chromium.org/2485843002/diff/100001/chromecast/browser/tes...
chromecast/browser/test/chromecast_browser_test.cc:27: CHECK(setup_called_) <<
"Overridden SetUp() did not call parent "
There is no need to check this here. It is already done in BrowserTestBase:
https://cs.chromium.org/chromium/src/content/public/test/browser_test_base.cc...

[derekjchow1, 2016-11-08 19:06:37]

lgtm % nit

https://codereview.chromium.org/2485843002/diff/100001/chromecast/browser/tes...
File chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc
(right):

https://codereview.chromium.org/2485843002/diff/100001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc:27: //
ChromecastBrowserTest overrides.
// ChromecastBrowserTest implementation:

To be consistent with chromecast/browser

[alokp, 2016-11-08 19:34:00]

https://codereview.chromium.org/2485843002/diff/100001/chromecast/browser/tes...
File chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc
(right):

https://codereview.chromium.org/2485843002/diff/100001/chromecast/browser/tes...
chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc:27: //
ChromecastBrowserTest overrides.
On 2016/11/08 19:06:37, derekjchow1 wrote:
> // ChromecastBrowserTest implementation:
> 
> To be consistent with chromecast/browser

Done.

[alokp, 2016-11-08 19:34:08]

The CQ bit was checked by alokp@chromium.org

[alokp, 2016-11-08 19:34:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
halliwell@chromium.org, derekjchow@chromium.org
Link to the patchset: https://codereview.chromium.org/2485843002/#ps120001
(title: "addressed comment")

[commit-bot: I haz the power, 2016-11-08 19:34:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 21:41:06]

Description was changed from

==========
[chromecast] Merge ChromecastBrowserTestHelper into ChromecastBrowserTest.

BUG=663067
TEST=cast_shell_browsertests
==========

to

==========
[chromecast] Merge ChromecastBrowserTestHelper into ChromecastBrowserTest.

BUG=663067
TEST=cast_shell_browsertests
==========

[commit-bot: I haz the power, 2016-11-08 21:41:08]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-11-08 21:50:10]

Description was changed from

==========
[chromecast] Merge ChromecastBrowserTestHelper into ChromecastBrowserTest.

BUG=663067
TEST=cast_shell_browsertests
==========

to

==========
[chromecast] Merge ChromecastBrowserTestHelper into ChromecastBrowserTest.

BUG=663067
TEST=cast_shell_browsertests

Committed: https://crrev.com/33c0d5d78594fa996cf23b3b608adacdc2a183f9
Cr-Commit-Position: refs/heads/master@{#430724}
==========

[commit-bot: I haz the power, 2016-11-08 21:50:11]

Patchset 7 (id:??) landed as
https://crrev.com/33c0d5d78594fa996cf23b3b608adacdc2a183f9
Cr-Commit-Position: refs/heads/master@{#430724}