Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc

Issue 2485843002: [chromecast] Merge ChromecastBrowserTestHelper into ChromecastBrowserTest (Closed)
Patch Set: addressed comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/browser/test/chromecast_shell_browser_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc
diff --git a/chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc b/chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc
index 9d650f09e46554193c3a9da9b732614c601ec28b..65065dec8a650bb35a6eb7f4d0d6fa900ce34c55 100644
--- a/chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc
+++ b/chromecast/browser/test/chromecast_shell_media_blocking_browser_test.cc
@@ -6,9 +6,10 @@
#include "base/run_loop.h"
#include "base/threading/platform_thread.h"
#include "base/threading/thread_task_runner_handle.h"
+#include "chromecast/browser/cast_media_blocker.h"
#include "chromecast/browser/test/chromecast_browser_test.h"
-#include "chromecast/browser/test/chromecast_browser_test_helper.h"
#include "chromecast/chromecast_features.h"
+#include "content/public/browser/media_session.h"
#include "content/public/browser/web_contents.h"
#include "content/public/test/browser_test_utils.h"
#include "media/base/test_data_util.h"
@@ -23,6 +24,13 @@ class ChromecastShellMediaBlockingBrowserTest : public ChromecastBrowserTest {
ChromecastShellMediaBlockingBrowserTest() {}
protected:
+ // ChromecastBrowserTest implementation.
+ void TearDownOnMainThread() override {
+ blocker_.reset();
+
+ ChromecastBrowserTest::TearDownOnMainThread();
+ }
+
void PlayMedia(const std::string& tag, const std::string& media_file) {
base::StringPairs query_params;
query_params.push_back(std::make_pair(tag, media_file));
@@ -32,12 +40,15 @@ class ChromecastShellMediaBlockingBrowserTest : public ChromecastBrowserTest {
GURL gurl = content::GetFileUrlWithQuery(
media::GetTestDataFilePath("player.html"), query);
- web_contents_ = helper_->NavigateToURL(gurl);
+ web_contents_ = NavigateToURL(gurl);
WaitForLoadStop(web_contents_);
+
+ blocker_ = base::MakeUnique<CastMediaBlocker>(
+ content::MediaSession::Get(web_contents_), web_contents_);
}
void BlockAndTestPlayerState(const std::string& media_type, bool blocked) {
- helper_->BlockMediaLoading(blocked);
+ blocker_->BlockMediaLoading(blocked);
// Changing states is not instant, but should be timely (< 0.5s).
for (size_t i = 0; i < 5; i++) {
@@ -68,9 +79,10 @@ class ChromecastShellMediaBlockingBrowserTest : public ChromecastBrowserTest {
<< " media element";
}
+ private:
content::WebContents* web_contents_;
+ std::unique_ptr<CastMediaBlocker> blocker_;
- private:
DISALLOW_COPY_AND_ASSIGN(ChromecastShellMediaBlockingBrowserTest);
};
« no previous file with comments | « chromecast/browser/test/chromecast_shell_browser_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698