Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: scripts/slave/recipes/android/perf.py

Issue 2485763002: Use devil's adb with each bisect iteration, also start/stop daemons. (Closed)
Patch Set: Whitespace cleanup. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« scripts/slave/recipe_modules/chromium_tests/api.py ('K') | « scripts/slave/recipe_modules/chromium_tests/api.py ('k') | scripts/slave/recipes/bisection/android_bisect.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/android/perf.py
diff --git a/scripts/slave/recipes/android/perf.py b/scripts/slave/recipes/android/perf.py
index fef941ded20b4ae44fbc3a6594316e86bb08d177..274bdacd8141bac74211f48857bc2d15ac26cea8 100644
--- a/scripts/slave/recipes/android/perf.py
+++ b/scripts/slave/recipes/android/perf.py
@@ -189,6 +189,8 @@ def RunSteps(api):
test_runner = api.chromium_tests.create_test_runner(
api, builder.get('tests', []))
+ api.chromium_android.logcat_gs_bucket = 'chromium-android'
jbudorick 2016/11/08 00:18:31 Same question.
ghost stip (do not use) 2016/11/08 20:56:33 sure, was just re-implementing the same logic. I c
+
try:
failures = []
if test_runner:
@@ -210,8 +212,7 @@ def RunSteps(api):
if failures:
raise api.step.StepFailure('src-side perf tests failed %s' % failures)
finally:
- api.chromium_android.common_tests_final_steps(
- logcat_gs_bucket='chromium-android')
+ api.chromium_android.common_tests_final_steps()
def _sanitize_nonalpha(text):
« scripts/slave/recipe_modules/chromium_tests/api.py ('K') | « scripts/slave/recipe_modules/chromium_tests/api.py ('k') | scripts/slave/recipes/bisection/android_bisect.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698