scripts/slave/recipe_modules/chromium_tests/api.py - Issue 2485763002: Use devil's adb with each bisect iteration, also start/stop daemons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/api.py

Issue 2485763002: Use devil's adb with each bisect iteration, also start/stop daemons. (Closed)

Patch Set: Whitespace cleanup. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/chromium_tests/api.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/api.py b/scripts/slave/recipe_modules/chromium_tests/api.py

index 6655fc7a161f8b4075ee387f4821d62156374302..a63c2d5b9278af540a25c80a10418c322cb16eca 100644

--- a/scripts/slave/recipe_modules/chromium_tests/api.py

+++ b/scripts/slave/recipe_modules/chromium_tests/api.py

@@ -616,8 +616,8 @@ class ChromiumTestsApi(recipe_api.RecipeApi):

if self.m.chromium.c.TARGET_PLATFORM == 'android':

if require_device_steps:

- self.m.chromium_android.common_tests_final_steps(

- logcat_gs_bucket='chromium-android')

+ self.m.chromium_android.logcat_gs_bucket = 'chromium-android'

jbudorick 2016/11/08 00:18:31 If this is the default, why do we need to specify

+ self.m.chromium_android.common_tests_final_steps()

else:

self.m.chromium_android.test_report()