Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2485733002: Switch NTP to use the string for downloading a page. (Closed)

Created:
4 years, 1 month ago by dewittj
Modified:
4 years, 1 month ago
Reviewers:
PEConn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Switch NTP to use the string for downloading a page. * before: Save linked page for later * after: Download link BUG=662105 TBR=peconn@chromium.org Review-Url: https://codereview.chromium.org/2480643002 Cr-Commit-Position: refs/heads/master@{#429848} (cherry picked from commit d4f09d3d0165b9b5c8316b78d6186bcd7b6df8d4) Committed: https://chromium.googlesource.com/chromium/src/+/e64ee0d637f04d3c11c5af6a74fb2bd74a7c3e1c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (4 generated)
dewittj
About to manually land this to 2883 since the file from the original patch was ...
4 years, 1 month ago (2016-11-07 21:52:54 UTC) #4
dewittj
4 years, 1 month ago (2016-11-07 23:23:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e64ee0d637f04d3c11c5af6a74fb2bd74a7c3e1c.

Powered by Google App Engine
This is Rietveld 408576698