Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2480643002: Switch NTP to use the string for downloading a page. (Closed)

Created:
4 years, 1 month ago by dewittj
Modified:
4 years, 1 month ago
Reviewers:
vitaliii, PEConn, dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch NTP to use the string for downloading a page. * before: Save linked page for later * after: Download link BUG=662105 Committed: https://crrev.com/d4f09d3d0165b9b5c8316b78d6186bcd7b6df8d4 Cr-Commit-Position: refs/heads/master@{#429848}

Patch Set 1 #

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/ContextMenuHandler.java View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
dewittj
PTAL, this reflects what I think was agreed upon in our email thread about the ...
4 years, 1 month ago (2016-11-04 00:11:01 UTC) #4
PEConn
On 2016/11/04 00:11:01, dewittj wrote: > PTAL, this reflects what I think was agreed upon ...
4 years, 1 month ago (2016-11-04 10:41:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480643002/20001
4 years, 1 month ago (2016-11-04 10:42:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 10:47:09 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 10:50:25 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4f09d3d0165b9b5c8316b78d6186bcd7b6df8d4
Cr-Commit-Position: refs/heads/master@{#429848}

Powered by Google App Engine
This is Rietveld 408576698