Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2485673002: Bundle some ash resources into chrome for mash=1 use_ash=0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by tonikitoo
Modified:
4 months, 3 weeks ago
Reviewers:
Tom Anderson, sky
CC:
chromium-reviews, fwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bundle some ash resources into chrome for mash=1 use_ash=0 Today it is possible to build the 'chrome' target with mash enabled on both ChromeOS and Linux desktop builds, by setting 'enable_package_mash_services=true' in the GN arguments. In case of ChromeOS builds, 'use_ash' is enabled by default, and the ash resources (localized strings, icons, etc), are bundled into the 'chrome' executable just normally. In case of non-chromeos mash builds though, although 'use_ash' is false by default, some code in //src/ash/ is still used because //chrome/app/mash does depend on ash. This CL temporarily allows some ash_resources to be bundled into 'chrome', when 'enable_package_mash_services' is true. In practice, without the ash_resources bundled into chrome, chrome launches like https://goo.gl/9mbQA5 (see the missing resources). On the other hand, with the ash_resource bundled, chrome launches like https://goo.gl/0R9Sl3 . BUG=

Patch Set 1 : draft #

Patch Set 2 : Bundle some ash resources into chrome for mash=1 use_ash=0 #

Patch Set 3 : Bundle some ash resources into chrome for mash=1 use_ash=0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/chrome_paks.gni View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/chrome_repack_locales.gni View 1 2 chunks +5 lines, -1 line 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 5 (3 generated)
tonikitoo
Spin off of https://codereview.chromium.org/2408803002/ @sky: I tried to explain in the commit message the reason, ...
6 months, 3 weeks ago (2016-11-09 20:26:30 UTC) #4
sky
6 months, 3 weeks ago (2016-11-09 22:27:33 UTC) #5
Again, I think this is the wrong way to go about this. You shouldn't be
compiling ash files in a non-ash build.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06