Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2485573009: DevTools: Move the Run Snippet button into the status bar. (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
lushnikov
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Move the Run Snippet button into the status bar. BUG=657982 Committed: https://crrev.com/6a4e7f8ba35f2ddbec1bfd97468cd044cf07cb02 Cr-Commit-Position: refs/heads/master@{#431093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 4 chunks +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
einbinder
ptal Screenshots: http://i.imgur.com/wBv9nwf.png http://i.imgur.com/zjygvE7.png
4 years, 1 month ago (2016-11-09 02:47:00 UTC) #2
lushnikov
beautiful. lgtm
4 years, 1 month ago (2016-11-09 21:49:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485573009/1
4 years, 1 month ago (2016-11-09 21:49:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-10 00:18:42 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-10 00:28:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a4e7f8ba35f2ddbec1bfd97468cd044cf07cb02
Cr-Commit-Position: refs/heads/master@{#431093}

Powered by Google App Engine
This is Rietveld 408576698