Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2485573009: DevTools: Move the Run Snippet button into the status bar. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index 8af370ce7610a981b24dd788796cf8a4a25a1ea1..3eb572c9ff6698ef8a436ed1844f580c1f698c3d 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -41,8 +41,6 @@ WebInspector.SourcesPanel = class extends WebInspector.Panel {
this._workspace = WebInspector.workspace;
this._networkMapping = WebInspector.networkMapping;
- this._runSnippetAction =
- /** @type {!WebInspector.Action }*/ (WebInspector.actionRegistry.action('debugger.run-snippet'));
this._togglePauseAction =
/** @type {!WebInspector.Action }*/ (WebInspector.actionRegistry.action('debugger.toggle-pause'));
this._stepOverAction =
@@ -84,13 +82,11 @@ WebInspector.SourcesPanel = class extends WebInspector.Panel {
this._sourcesView = new WebInspector.SourcesView();
this._sourcesView.addEventListener(WebInspector.SourcesView.Events.EditorSelected, this._editorSelected.bind(this));
- this._sourcesView.addEventListener(WebInspector.SourcesView.Events.EditorClosed, this._editorClosed.bind(this));
this._sourcesView.registerShortcuts(this.registerShortcuts.bind(this));
this._toggleNavigatorSidebarButton = this.editorView.createShowHideSidebarButton('navigator');
this._toggleDebuggerSidebarButton = this._splitWidget.createShowHideSidebarButton('debugger');
this.editorView.setMainWidget(this._sourcesView);
- this._editorChanged(this._sourcesView.currentUISourceCode());
this._threadsSidebarPane = null;
this._watchSidebarPane = /** @type {!WebInspector.View} */ (WebInspector.viewManager.view('sources.watch'));
@@ -563,29 +559,11 @@ WebInspector.SourcesPanel = class extends WebInspector.Panel {
*/
_editorSelected(event) {
var uiSourceCode = /** @type {!WebInspector.UISourceCode} */ (event.data);
- this._editorChanged(uiSourceCode);
if (this.editorView.mainWidget() && WebInspector.moduleSetting('autoRevealInNavigator').get())
this._revealInNavigator(uiSourceCode, true);
}
/**
- * @param {!WebInspector.Event} event
- */
- _editorClosed(event) {
- var wasSelected = /** @type {boolean} */ (event.data.wasSelected);
- if (wasSelected)
- this._editorChanged(null);
- }
-
- /**
- * @param {?WebInspector.UISourceCode} uiSourceCode
- */
- _editorChanged(uiSourceCode) {
- var isSnippet = uiSourceCode && uiSourceCode.project().type() === WebInspector.projectTypes.Snippets;
- this._runSnippetButton.setVisible(isSnippet);
- }
-
- /**
* @return {boolean}
*/
_togglePause() {
@@ -707,10 +685,6 @@ WebInspector.SourcesPanel = class extends WebInspector.Panel {
_createDebugToolbar() {
var debugToolbar = new WebInspector.Toolbar('scripts-debug-toolbar');
- this._runSnippetButton = WebInspector.Toolbar.createActionButton(this._runSnippetAction);
- debugToolbar.appendToolbarItem(this._runSnippetButton);
- this._runSnippetButton.setVisible(false);
-
var longResumeButton = new WebInspector.ToolbarButton(
WebInspector.UIString('Resume with all pauses blocked for 500 ms'), 'play-toolbar-item');
longResumeButton.addEventListener('click', this._longResume.bind(this), this);

Powered by Google App Engine
This is Rietveld 408576698