gn: Make generation of main build.ninja file deterministic.

gn: Make generation of main build.ninja file deterministic.

Follow-up to https://codereview.chromium.org/1494883002/ which either missed
the main build.ninja file, or build.ninja file writing has since gotten
nondetermistic again.

Fixes three cases of nondeterminism in build.ninja:
* Order of pools
* Order of subninjas for each toolchain
* Order of phony targets in build.ninja

BUG=662750, 565075
Committed: https://crrev.com/8c2865318628b91312ea2bfa065590e3dc4f920a
Cr-Commit-Position: refs/heads/master@{#430416}

[Nico, 2016-11-06 22:18:08]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[Nico, 2016-11-06 22:18:09]

thakis@chromium.org changed reviewers:
+ brettw@chromium.org

[Nico, 2016-11-06 22:18:10]

https://codereview.chromium.org/2485523002/diff/1/tools/gn/builder.h
File tools/gn/builder.h (right):

https://codereview.chromium.org/2485523002/diff/1/tools/gn/builder.h#newcode133
tools/gn/builder.h:133: typedef std::map<Label, BuilderRecord*> RecordMap;
Label has an operator<, so just use that ordering.

https://codereview.chromium.org/2485523002/diff/1/tools/gn/ninja_build_writer.cc
File tools/gn/ninja_build_writer.cc (right):

https://codereview.chromium.org/2485523002/diff/1/tools/gn/ninja_build_writer...
tools/gn/ninja_build_writer.cc:171: std::unordered_map<const Settings*, const
Toolchain*> used_toolchains;
An ordering on pointer values isn't very useful, so might as well make this an
unordered_map while here.

https://codereview.chromium.org/2485523002/diff/1/tools/gn/ninja_build_writer...
tools/gn/ninja_build_writer.cc:264: std::unordered_set<const Pool*> used_pools;
Same here.

[commit-bot: I haz the power, 2016-11-06 22:18:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nico, 2016-11-06 22:18:50]

Description was changed from

==========
gn: Make generation of main build.ninja file deterministic.

Follow-up to https://codereview.chromium.org/1494883002/ which either missed
the main build.ninja file, or build.ninja file writing has since gotten
nondetermistic again.

BUG=662750,565075
==========

to

==========
gn: Make generation of main build.ninja file deterministic.

Follow-up to https://codereview.chromium.org/1494883002/ which either missed
the main build.ninja file, or build.ninja file writing has since gotten
nondetermistic again.

Fixes three cases of nondeterminism in build.ninja:
* Order of pools
* Order of subninjas for each toolchain
* Order of phony targets in build.ninja

BUG=662750,565075
==========

[commit-bot: I haz the power, 2016-11-06 22:22:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 22:22:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2016-11-06 22:34:42]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-06 22:34:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 22:39:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 22:39:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Nico, 2016-11-06 22:46:44]

The CQ bit was checked by thakis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-06 22:46:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-06 23:01:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-06 23:01:08]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-11-07 22:36:19]

lgtm

[Nico, 2016-11-07 22:58:38]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-11-07 22:59:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 23:30:14]

Description was changed from

==========
gn: Make generation of main build.ninja file deterministic.

Follow-up to https://codereview.chromium.org/1494883002/ which either missed
the main build.ninja file, or build.ninja file writing has since gotten
nondetermistic again.

Fixes three cases of nondeterminism in build.ninja:
* Order of pools
* Order of subninjas for each toolchain
* Order of phony targets in build.ninja

BUG=662750,565075
==========

to

==========
gn: Make generation of main build.ninja file deterministic.

Follow-up to https://codereview.chromium.org/1494883002/ which either missed
the main build.ninja file, or build.ninja file writing has since gotten
nondetermistic again.

Fixes three cases of nondeterminism in build.ninja:
* Order of pools
* Order of subninjas for each toolchain
* Order of phony targets in build.ninja

BUG=662750,565075
==========

[commit-bot: I haz the power, 2016-11-07 23:30:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-07 23:36:11]

Description was changed from

==========
gn: Make generation of main build.ninja file deterministic.

Follow-up to https://codereview.chromium.org/1494883002/ which either missed
the main build.ninja file, or build.ninja file writing has since gotten
nondetermistic again.

Fixes three cases of nondeterminism in build.ninja:
* Order of pools
* Order of subninjas for each toolchain
* Order of phony targets in build.ninja

BUG=662750,565075
==========

to

==========
gn: Make generation of main build.ninja file deterministic.

Follow-up to https://codereview.chromium.org/1494883002/ which either missed
the main build.ninja file, or build.ninja file writing has since gotten
nondetermistic again.

Fixes three cases of nondeterminism in build.ninja:
* Order of pools
* Order of subninjas for each toolchain
* Order of phony targets in build.ninja

BUG=662750,565075

Committed: https://crrev.com/8c2865318628b91312ea2bfa065590e3dc4f920a
Cr-Commit-Position: refs/heads/master@{#430416}
==========

[commit-bot: I haz the power, 2016-11-07 23:36:12]

Patchset 3 (id:??) landed as
https://crrev.com/8c2865318628b91312ea2bfa065590e3dc4f920a
Cr-Commit-Position: refs/heads/master@{#430416}