Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef TOOLS_GN_BUILDER_H_ | 5 #ifndef TOOLS_GN_BUILDER_H_ |
| 6 #define TOOLS_GN_BUILDER_H_ | 6 #define TOOLS_GN_BUILDER_H_ |
| 7 | 7 |
| 8 #include "base/callback.h" | 8 #include "base/callback.h" |
| 9 #include "base/containers/hash_tables.h" | 9 #include "base/containers/hash_tables.h" |
| 10 #include "base/macros.h" | 10 #include "base/macros.h" |
| (...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 123 // Given a list of unresolved records, tries to find any circular | 123 // Given a list of unresolved records, tries to find any circular |
| 124 // dependencies and returns the string describing the problem. If no circular | 124 // dependencies and returns the string describing the problem. If no circular |
| 125 // deps were found, returns the empty string. | 125 // deps were found, returns the empty string. |
| 126 std::string CheckForCircularDependencies( | 126 std::string CheckForCircularDependencies( |
| 127 const std::vector<const BuilderRecord*>& bad_records) const; | 127 const std::vector<const BuilderRecord*>& bad_records) const; |
| 128 | 128 |
| 129 // Non owning pointer. | 129 // Non owning pointer. |
| 130 Loader* loader_; | 130 Loader* loader_; |
| 131 | 131 |
| 132 // Owning pointers. | 132 // Owning pointers. |
| 133 typedef base::hash_map<Label, BuilderRecord*> RecordMap; | 133 typedef std::map<Label, BuilderRecord*> RecordMap; |
|
Nico
2016/11/06 22:18:10
Label has an operator<, so just use that ordering.
| |
| 134 RecordMap records_; | 134 RecordMap records_; |
| 135 | 135 |
| 136 ResolvedGeneratedCallback resolved_and_generated_callback_; | 136 ResolvedGeneratedCallback resolved_and_generated_callback_; |
| 137 | 137 |
| 138 DISALLOW_COPY_AND_ASSIGN(Builder); | 138 DISALLOW_COPY_AND_ASSIGN(Builder); |
| 139 }; | 139 }; |
| 140 | 140 |
| 141 #endif // TOOLS_GN_BUILDER_H_ | 141 #endif // TOOLS_GN_BUILDER_H_ |
| OLD | NEW |