Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: cc/surfaces/surface_manager_ref_unittest.cc

Issue 2485473003: Remove SurfaceFactory::Create and SurfaceFactory::Destroy (Closed)
Patch Set: up Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surface_manager_ref_unittest.cc
diff --git a/cc/surfaces/surface_manager_ref_unittest.cc b/cc/surfaces/surface_manager_ref_unittest.cc
index 7a7ab5e40fa5e28526292af67eb4188344bb4f5d..1d29cf31c4015c239ced24b5a5d2242a9ca230b6 100644
--- a/cc/surfaces/surface_manager_ref_unittest.cc
+++ b/cc/surfaces/surface_manager_ref_unittest.cc
@@ -33,13 +33,17 @@ class SurfaceManagerRefTest : public testing::Test {
// SurfaceFactory for |frame_sink_id| if necessary.
SurfaceId CreateSurface(const FrameSinkId& frame_sink_id,
Fady Samuel 2016/11/08 22:23:59 This method doesn't really make sense.
Saman Sami 2016/11/11 17:49:58 Since the code never sends a frame, I have to do t
const LocalFrameId& local_frame_id) {
- GetFactory(frame_sink_id).Create(local_frame_id);
+ GetFactory(frame_sink_id)
+ .SubmitCompositorFrame(local_frame_id, CompositorFrame(),
+ SurfaceFactory::DrawCallback());
return SurfaceId(frame_sink_id, local_frame_id);
}
// Destroy Surface with |surface_id|.
void DestroySurface(const SurfaceId& surface_id) {
Fady Samuel 2016/11/08 22:23:59 This method doesn't really make sense.
Saman Sami 2016/11/11 17:49:58 Same
- GetFactory(surface_id.frame_sink_id()).Destroy(surface_id.local_frame_id());
+ GetFactory(surface_id.frame_sink_id())
+ .SubmitCompositorFrame(LocalFrameId(), CompositorFrame(),
+ SurfaceFactory::DrawCallback());
}
protected:

Powered by Google App Engine
This is Rietveld 408576698