Remove SurfaceFactory::Create and SurfaceFactory::Destroy

cc/surfaces/surface_manager_ref_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <unordered_map>
 #include <vector>
 
 #include "base/memory/ptr_util.h"
@@ skipping 13 matching lines @@
 constexpr LocalFrameId kLocalFrame1(1, 0);
 constexpr LocalFrameId kLocalFrame2(2, 0);
 
 // Tests for reference tracking in SurfaceManager.
 class SurfaceManagerRefTest : public testing::Test {
  public:
   SurfaceManager& manager() { return *manager_; }
 
   // Creates a new Surface with the provided SurfaceId. Will first create the
   // SurfaceFactory for |frame_sink_id| if necessary.
   SurfaceId CreateSurface(const FrameSinkId& frame_sink_id,

[Fady Samuel, 2016/11/08 22:23:59]

This method doesn't really make sense.

[Saman Sami, 2016/11/11 17:49:58]

Since the code never sends a frame, I have to do this.

                           const LocalFrameId& local_frame_id) {
-    GetFactory(frame_sink_id).Create(local_frame_id);
+    GetFactory(frame_sink_id)
+        .SubmitCompositorFrame(local_frame_id, CompositorFrame(),
+                               SurfaceFactory::DrawCallback());
     return SurfaceId(frame_sink_id, local_frame_id);
   }
 
   // Destroy Surface with |surface_id|.
   void DestroySurface(const SurfaceId& surface_id) {

[Fady Samuel, 2016/11/08 22:23:59]

This method doesn't really make sense.

[Saman Sami, 2016/11/11 17:49:58]

Same

-    GetFactory(surface_id.frame_sink_id()).Destroy(surface_id.local_frame_id());
+    GetFactory(surface_id.frame_sink_id())
+        .SubmitCompositorFrame(LocalFrameId(), CompositorFrame(),
+                               SurfaceFactory::DrawCallback());
   }
 
  protected:
   SurfaceFactory& GetFactory(const FrameSinkId& frame_sink_id) {
     auto& factory_ptr = factories_[frame_sink_id];
     if (!factory_ptr)
       factory_ptr = base::MakeUnique<SurfaceFactory>(frame_sink_id,
                                                      manager_.get(), nullptr);
     return *factory_ptr;
   }
@@ skipping 231 matching lines @@
   SurfaceId id2 = CreateSurface(kFrameSink2, kLocalFrame1);
 
   // Removing non-existent reference should be ignored.
   manager().AddSurfaceReference(id1, id2);
   manager().RemoveSurfaceReference(id2, id1);
   EXPECT_EQ(manager().GetReferencedSurfaceCount(id1), 1u);
   EXPECT_EQ(manager().GetSurfaceReferenceCount(id2), 1u);
 }
 
 }  // namespace cc