Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2485323002: Fix delegate check BlimpClientContextImpl::SetDelegate (Closed)

Created:
4 years, 1 month ago by Menglin
Modified:
4 years, 1 month ago
Reviewers:
Khushal
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix delegate check BlimpClientContextImpl::SetDelegate In https://codereview.chromium.org/2463423002/, the check was changed to DCHECK(!delegate_ && delegate) assuming we don't support clearing the delegate. But we do https://cs.chromium.org/chromium/src/chrome/browser/android/blimp/chrome_blimp_client_context_delegate.cc?l=33 so changing it back, and add this to the unit test. BUG= Committed: https://crrev.com/67574edeaae89b934ce667a0680d178f924df26a Cr-Commit-Position: refs/heads/master@{#430943}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M blimp/client/core/context/blimp_client_context_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/core/context/blimp_client_context_impl_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Menglin
Hi Khushal, ptal. Thanks! Menglin
4 years, 1 month ago (2016-11-09 01:42:35 UTC) #4
Khushal
lgtm
4 years, 1 month ago (2016-11-09 01:49:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2485323002/1
4 years, 1 month ago (2016-11-09 16:09:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-09 16:14:08 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-09 16:16:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67574edeaae89b934ce667a0680d178f924df26a
Cr-Commit-Position: refs/heads/master@{#430943}

Powered by Google App Engine
This is Rietveld 408576698