blimp/client/core/context/blimp_client_context_impl.cc - Issue 2485323002: Fix delegate check BlimpClientContextImpl::SetDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/context/blimp_client_context_impl.cc

Issue 2485323002: Fix delegate check BlimpClientContextImpl::SetDelegate (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/core/context/blimp_client_context_impl.cc

diff --git a/blimp/client/core/context/blimp_client_context_impl.cc b/blimp/client/core/context/blimp_client_context_impl.cc

index e6261240351f4980986032c4ecd77014baee57bd..b870611507e9c3ed499c2c5d759ca71be2d5ee88 100644

--- a/blimp/client/core/context/blimp_client_context_impl.cc

+++ b/blimp/client/core/context/blimp_client_context_impl.cc

@@ -158,7 +158,7 @@ BlimpClientContextImpl::~BlimpClientContextImpl() {

}

void BlimpClientContextImpl::SetDelegate(BlimpClientContextDelegate* delegate) {

- DCHECK(!delegate_ && delegate);

+ DCHECK(!delegate_ || !delegate);

delegate_ = delegate;

// TODO(xingliu): Pass the IdentityProvider needed by |assignment_fetcher_|

« no previous file with comments | « no previous file | blimp/client/core/context/blimp_client_context_impl_unittest.cc » ('j') | no next file with comments »