Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2485253005:
CopyTexImage2D: don't pick invalid unsized internal formats on ES3 (Closed)
|
Created:
4 years, 1 month ago by Kai Ninomiya Modified:
4 years, 1 month ago CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionCopyTexImage2D: don't pick invalid unsized internal formats on ES3
BUG=663280
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/4bfbee6de3147817abcb991177176df00c401046
Cr-Commit-Position: refs/heads/master@{#431437}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : simplify #
Total comments: 3
Patch Set 4 : more detailed comments #Messages
Total messages: 24 (15 generated)
Description was changed from ========== properly validate unsized internal formats on ES3 in DoCopyTexImage2D BUG=663280 ========== to ========== properly validate unsized internal formats on ES3 in DoCopyTexImage2D BUG=663280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== properly validate unsized internal formats on ES3 in DoCopyTexImage2D BUG=663280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== CopyTexImage2D: don't pick invalid unsized internal formats on ES3 BUG=663280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
kainino@chromium.org changed reviewers: + zmo@chromium.org
zmo, PTAL
I looked at other entry points and I'm pretty sure this is the only one which
will need this fix. This logic is specific to CopyTexImage2D because (as piman's
TODO says) it's fudging the logic in section 3.8.5 of the ES3 spec ("If
internalformat is unsized...").
kbr@chromium.org changed reviewers: + kbr@chromium.org
https://codereview.chromium.org/2485253005/diff/40001/gpu/command_buffer/serv... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2485253005/diff/40001/gpu/command_buffer/serv... gpu/command_buffer/service/gles2_cmd_decoder.cc:13835: // Other unsized internal_formats are invalid in ES3. Is this correct? ES spec 3.0.5, section 3.7, table 3.3 (page 113) supports the packed types (UNSIGNED_SHORT_4_4_4_4, UNSIGNED_SHORT_5_5_5_1, UNSIGNED_SHORT_5_6_5) too.
https://codereview.chromium.org/2485253005/diff/40001/gpu/command_buffer/serv... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2485253005/diff/40001/gpu/command_buffer/serv... gpu/command_buffer/service/gles2_cmd_decoder.cc:13835: // Other unsized internal_formats are invalid in ES3. On 2016/11/10 23:32:30, Ken Russell wrote: > Is this correct? ES spec 3.0.5, section 3.7, table 3.3 (page 113) supports the > packed types (UNSIGNED_SHORT_4_4_4_4, UNSIGNED_SHORT_5_5_5_1, > UNSIGNED_SHORT_5_6_5) too. Also, please refer to this table in a comment.
https://codereview.chromium.org/2485253005/diff/40001/gpu/command_buffer/serv... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2485253005/diff/40001/gpu/command_buffer/serv... gpu/command_buffer/service/gles2_cmd_decoder.cc:13835: // Other unsized internal_formats are invalid in ES3. On 2016/11/10 23:32:55, Ken Russell wrote: > On 2016/11/10 23:32:30, Ken Russell wrote: > > Is this correct? ES spec 3.0.5, section 3.7, table 3.3 (page 113) supports the > > packed types (UNSIGNED_SHORT_4_4_4_4, UNSIGNED_SHORT_5_5_5_1, > > UNSIGNED_SHORT_5_6_5) too. > > Also, please refer to this table in a comment. Done.
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
Thanks for updating the comments; LGTM too.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by kainino@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by kainino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== CopyTexImage2D: don't pick invalid unsized internal formats on ES3 BUG=663280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== CopyTexImage2D: don't pick invalid unsized internal formats on ES3 BUG=663280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== CopyTexImage2D: don't pick invalid unsized internal formats on ES3 BUG=663280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== CopyTexImage2D: don't pick invalid unsized internal formats on ES3 BUG=663280 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4bfbee6de3147817abcb991177176df00c401046 Cr-Commit-Position: refs/heads/master@{#431437} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/4bfbee6de3147817abcb991177176df00c401046 Cr-Commit-Position: refs/heads/master@{#431437} |
