CopyTexImage2D: don't pick invalid unsized internal formats on ES3

gpu/command_buffer/service/gles2_cmd_decoder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
@@ skipping 13801 matching lines @@
     return;
   }
 
   uint32_t pixels_size = 0;
   // TODO(piman): OpenGL ES 3.0.4 Section 3.8.5 specifies how to pick an
   // effective internal format if internal_format is unsized, which is a fairly
   // involved logic. For now, just make sure we pick something valid.
   GLenum format =
       TextureManager::ExtractFormatFromStorageFormat(internal_format);
   GLenum type = TextureManager::ExtractTypeFromStorageFormat(internal_format);
+  bool internal_format_unsized = internal_format == format;
+  if (internal_format_unsized && feature_info_->IsWebGL2OrES3Context()) {
+    // The picks made by the temporary logic above may not be valid on ES3.
+    DCHECK(type == GL_UNSIGNED_BYTE);
+    switch (internal_format) {
+      case GL_RGB:
+      case GL_RGBA:
+      case GL_LUMINANCE_ALPHA:
+      case GL_LUMINANCE:
+      case GL_ALPHA:
+      case GL_BGRA_EXT:
+        break;
+      default:
+        // Other unsized internal_formats are invalid in ES3.

[Ken Russell (switch to Gerrit), 2016/11/10 23:32:30]

Is this correct? ES spec 3.0.5, section 3.7, table 3.3 (page 113) supports the
packed types (UNSIGNED_SHORT_4_4_4_4, UNSIGNED_SHORT_5_5_5_1,
UNSIGNED_SHORT_5_6_5) too.

[Ken Russell (switch to Gerrit), 2016/11/10 23:32:55]

Also, please refer to this table in a comment.

[Kai Ninomiya, 2016/11/10 23:50:00]

Done.

+        format = GL_NONE;
+        break;
+    }
+  }
   if (!format || !type) {
     LOCAL_SET_GL_ERROR(
         GL_INVALID_OPERATION,
         func_name, "Invalid unsized internal format.");
     return;
   }
 
   DCHECK(texture_manager()->ValidateTextureParameters(
       GetErrorState(), func_name, true, format, type, internal_format, level));
 
@@ skipping 4969 matching lines @@
 }
 
 // Include the auto-generated part of this file. We split this because it means
 // we can easily edit the non-auto generated parts right here in this file
 // instead of having to edit some template or the code generator.
 #include "base/macros.h"
 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
 
 }  // namespace gles2
 }  // namespace gpu