ios/chrome/browser/browser_about_rewriter.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/browser_about_rewriter.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/browser_about_rewriter.cc

diff --git a/ios/chrome/browser/browser_about_rewriter.cc b/ios/chrome/browser/browser_about_rewriter.cc

index 0920c682a06b9a792aa344edaf0d88ec913c51c7..caf8df4bcb5a8ff312b3edd16d41db9d75cd07db 100644

--- a/ios/chrome/browser/browser_about_rewriter.cc

+++ b/ios/chrome/browser/browser_about_rewriter.cc

@@ -32,8 +32,7 @@ bool WillHandleWebBrowserAboutURL(GURL* url, web::BrowserState* browser_state) {

*url = url_formatter::FixupURL(url->possibly_invalid_spec(), std::string());

// Check that about: URLs are fixed up to chrome: by url_formatter::FixupURL.

- DCHECK((*url == GURL(url::kAboutBlankURL)) ||

- !url->SchemeIs(url::kAboutScheme));

+ DCHECK((*url == url::kAboutBlankURL) || !url->SchemeIs(url::kAboutScheme));

// url_formatter::FixupURL translates about:foo into chrome://foo/.

if (!url->SchemeIs(kChromeUIScheme))