extensions/browser/guest_view/extension_view/extension_view_guest.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/extension_view/extension_view_guest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/data/dom_storage/webcore_test_database.localstorage ('k') | ios/chrome/browser/browser_about_rewriter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/extension_view/extension_view_guest.cc

diff --git a/extensions/browser/guest_view/extension_view/extension_view_guest.cc b/extensions/browser/guest_view/extension_view/extension_view_guest.cc

index aa3367f24df04646c5eeb6989ac62c8094cffa19..08508011eb48ecffee594cb256554196020065c7 100644

--- a/extensions/browser/guest_view/extension_view/extension_view_guest.cc

+++ b/extensions/browser/guest_view/extension_view/extension_view_guest.cc

@@ -47,8 +47,8 @@ bool ExtensionViewGuest::NavigateGuest(const std::string& src,

// If the URL is not valid, about:blank, or the same origin as the extension,

// then navigate to about:blank.

- bool url_not_allowed = url != GURL(url::kAboutBlankURL) &&

- !url::IsSameOriginWith(url, extension_url_);

+ bool url_not_allowed =

+ url != url::kAboutBlankURL && !url::IsSameOriginWith(url, extension_url_);

if (!url.is_valid() || url_not_allowed)

return NavigateGuest(url::kAboutBlankURL, true /* force_navigation */);

« no previous file with comments | « content/test/data/dom_storage/webcore_test_database.localstorage ('k') | ios/chrome/browser/browser_about_rewriter.cc » ('j') | no next file with comments »