chrome/browser/ui/search/search_tab_helper.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/search/search_tab_helper.cc

diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc

index f03b427cf95e11b8cfb2760f7671fb79a2981369..3875174c0eb231a5b39723cb0d2d8198be42cf93 100644

--- a/chrome/browser/ui/search/search_tab_helper.cc

+++ b/chrome/browser/ui/search/search_tab_helper.cc

@@ -59,7 +59,7 @@ bool IsCacheableNTP(const content::WebContents* contents) {

const content::NavigationEntry* entry =

contents->GetController().GetLastCommittedEntry();

return search::NavEntryIsInstantNTP(contents, entry) &&

- entry->GetURL() != GURL(chrome::kChromeSearchLocalNtpUrl);

+ entry->GetURL() != chrome::kChromeSearchLocalNtpUrl;

}

bool IsNTP(const content::WebContents* contents) {