chrome/browser/printing/cloud_print/privet_notifications_unittest.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc ('k') | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

diff --git a/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc b/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

index 8ef4c48a16eb0ac63f238d48400ed3a7168db0db..18249f8ef7d79d6c6f401800645e5902da9190fb 100644

--- a/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

+++ b/chrome/browser/printing/cloud_print/privet_notifications_unittest.cc

@@ -103,7 +103,7 @@ class PrivetNotificationsListenerTest : public testing::Test {

bool SuccessfulResponseToInfo(const std::string& response) {

net::TestURLFetcher* fetcher = fetcher_factory_.GetFetcherByID(0);

- if (!fetcher || GURL(kDeviceInfoURL) != fetcher->GetOriginalURL())

+ if (!fetcher || fetcher->GetOriginalURL() != kDeviceInfoURL)

return false;

fetcher->SetResponseString(response);