chrome/browser/history/history_tab_helper.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/history_tab_helper.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/history_tab_helper.cc

diff --git a/chrome/browser/history/history_tab_helper.cc b/chrome/browser/history/history_tab_helper.cc

index 9124655a5df01854dc13bf33cb57d5a750915b64..0117be104244d9ee3576af72af211fb497971615 100644

--- a/chrome/browser/history/history_tab_helper.cc

+++ b/chrome/browser/history/history_tab_helper.cc

@@ -69,7 +69,7 @@ HistoryTabHelper::CreateHistoryAddPageArgs(

// Clicks on content suggestions on the NTP should not contribute to the

// Most Visited tiles in the NTP.

const bool consider_for_ntp_most_visited =

- params.referrer.url != GURL(kChromeContentSuggestionsReferrer);

+ params.referrer.url != kChromeContentSuggestionsReferrer;

history::HistoryAddPageArgs add_page_args(

params.url, timestamp, history::ContextIDForWebContents(web_contents()),