chrome/browser/extensions/tab_helper.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/tab_helper.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/tab_helper.cc

diff --git a/chrome/browser/extensions/tab_helper.cc b/chrome/browser/extensions/tab_helper.cc

index db27af954d9d819fc70925105e29c416e54434bb..6468749b4d7abf88e5691ad228f4ae077ad157d3 100644

--- a/chrome/browser/extensions/tab_helper.cc

+++ b/chrome/browser/extensions/tab_helper.cc

@@ -441,7 +441,7 @@ void TabHelper::OnInlineWebstoreInstall(content::RenderFrameHost* host,

// child frames from sending the IPC.

if ((listeners_mask & ~(api::webstore::INSTALL_STAGE_LISTENER |

api::webstore::DOWNLOAD_PROGRESS_LISTENER)) != 0 ||

- !requestor_url.is_valid() || requestor_url == GURL(url::kAboutBlankURL) ||

+ !requestor_url.is_valid() || requestor_url == url::kAboutBlankURL ||

host->GetParent()) {

NOTREACHED();

return;