chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

diff --git a/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc b/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

index c037b1599bf31e474db41ada47027be8926d274d..59b5e53d0ba38331dadfd9baa879bdf8e791022c 100644

--- a/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

+++ b/chrome/browser/browsing_data/conditional_cache_deletion_helper_browsertest.cc

@@ -35,7 +35,7 @@ bool KeyIsEven(const disk_cache::Entry* entry) {

}

bool HasHttpsExampleOrigin(const GURL& url) {

- return url.GetOrigin() == GURL("https://example.com");

+ return url.GetOrigin() == "https://example.com/";

}

} // namespace

« no previous file with comments | « chrome/browser/browser_about_handler.cc ('k') | chrome/browser/captive_portal/captive_portal_browsertest.cc » ('j') | no next file with comments »