chrome/browser/browser_about_handler.cc - Issue 2485253002: Remove unnecessary calls to GURL()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)

Patch Set: Assert that StringPiece must always be canonicalized. Fix some constants. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browser_about_handler.cc

diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc

index 30899a53a8e80f8df22ad8feaa40252a50c1c953..ea5bde7e1ae4eb3c691ed0ab8059cb0df71f8d4c 100644

--- a/chrome/browser/browser_about_handler.cc

+++ b/chrome/browser/browser_about_handler.cc

@@ -42,7 +42,7 @@ bool WillHandleBrowserAboutURL(GURL* url,

FixupBrowserAboutURL(url, browser_context);

// Check that about: URLs are fixed up to chrome: by url_formatter::FixupURL.

- DCHECK((*url == GURL(url::kAboutBlankURL)) ||

+ DCHECK((*url == url::kAboutBlankURL) ||

!url->SchemeIs(url::kAboutScheme));

// Only handle chrome://foo/, url_formatter::FixupURL translates about:foo.