Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/android/data_usage/data_use_ui_tab_model.cc

Issue 2485253002: Remove unnecessary calls to GURL() (Closed)
Patch Set: Fix broken tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/browser/aw_permission_manager_unittest.cc ('k') | chrome/browser/bookmarks/managed_bookmark_service_unittest.cc » ('j') | chrome/browser/bookmarks/managed_bookmark_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/data_usage/data_use_ui_tab_model.cc
diff --git a/chrome/browser/android/data_usage/data_use_ui_tab_model.cc b/chrome/browser/android/data_usage/data_use_ui_tab_model.cc
index 8db9e0e5e78dec9ac28a58e260d1c6ac921fc060..44d929d9be056c744ff92338f1adedb47f711b3b 100644
--- a/chrome/browser/android/data_usage/data_use_ui_tab_model.cc
+++ b/chrome/browser/android/data_usage/data_use_ui_tab_model.cc
@@ -192,7 +192,7 @@ bool DataUseUITabModel::WouldDataUseTrackingEnd(
// current navigation.
navigation_entry = nullptr;
}
- DCHECK(!navigation_entry || (navigation_entry->GetURL() == GURL(url)));
+ DCHECK(!navigation_entry || (navigation_entry->GetURL() == url));
esprehn 2016/11/09 21:09:25 why don't we need to canonicalize url?
cfredric 2016/11/09 22:12:46 I'm not sure that we don't. Changed back.
if (!data_use_tab_model_)
return false;
« no previous file with comments | « android_webview/browser/aw_permission_manager_unittest.cc ('k') | chrome/browser/bookmarks/managed_bookmark_service_unittest.cc » ('j') | chrome/browser/bookmarks/managed_bookmark_service_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698