Remove unnecessary calls to GURL()

chrome/browser/android/data_usage/data_use_ui_tab_model.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/data_usage/data_use_ui_tab_model.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "chrome/common/url_constants.h"
@@ skipping 164 matching lines @@
   DCHECK(thread_checker_.CalledOnValidThread());
 
   TabEvents::const_iterator it = tab_events_.find(tab_id);
 
   if (it != tab_events_.end() && it->second == DATA_USE_CONTINUE_CLICKED)
     return false;
 
   DataUseTabModel::TransitionType transition_type;
 
   if (!ConvertTransitionType(ui::PageTransitionFromInt(page_transition),
                              GURL(url), &transition_type)) {

[Charlie Harrison, 2016/11/09 21:12:58]

Note that we GURL(url) here. Let's just use that, as I'm not sure |url| will
always be canonicalized here.

[cfredric, 2016/11/09 22:12:46]

Done.

     return false;
   }
 
   if (transition_type != DataUseTabModel::TRANSITION_FORWARD_BACK) {
     // NavigationEntry is only needed for back-forward navigations. For other
     // navigations, such as redirects, NavigationEntry may not correspond to the
     // current navigation.
     navigation_entry = nullptr;
   }
-  DCHECK(!navigation_entry || (navigation_entry->GetURL() == GURL(url)));
+  DCHECK(!navigation_entry || (navigation_entry->GetURL() == url));

[esprehn, 2016/11/09 21:09:25]

why don't we need to canonicalize url?

[cfredric, 2016/11/09 22:12:46]

I'm not sure that we don't. Changed back.

 
   if (!data_use_tab_model_)
     return false;
 
   return data_use_tab_model_->WouldNavigationEventEndTracking(
       tab_id, transition_type, GURL(url), navigation_entry);
 }
 
 void DataUseUITabModel::UserClickedContinueOnDialogBox(
     SessionID::id_type tab_id) {
@@ skipping 138 matching lines @@
       data_use_tab_model_->OnNavigationEvent(
           ui_event.tab_id, ui_event.transition_type, ui_event.url,
           ui_event.package, nullptr);
     }
   }
 }
 
 }  // namespace android
 
 }  // namespace chrome