Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 2485193002: Reland of [ObjC ARC] Converts crw_web_controller to ARC. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [ObjC ARC] Converts crw_web_controller to ARC. Notable changes: * crw_web_controller.mm used to have a dictionary storing selectors just for keeping the KVO code clean. ARC cannot call a selector from a string like this, because it cannot guarantee correct memory management in this case. So it was replaced with an array of observed key paths to keep some of the code cleanness, while the KVO callback has a huge switch. BUG=624365, 663105 TEST=None

Patch Set 1 #

Patch Set 2 : Disable DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -131 lines) Patch
M ios/chrome/browser/installation_notifier.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/web/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 1 chunk +9 lines, -9 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 39 chunks +94 lines, -119 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698