Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2453473002: Zero-out crw_web_controller's container view delegate in dealloc. (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Zero-out crw_web_controller's container view delegate in dealloc. Exposes delegate setter on CRWWebControllerContainerView and sets it to zero in CRWWebController dealloc. BUG=None TEST=None Committed: https://crrev.com/8f3eb56c71f307254488a00cbe09a7561149ed41 Cr-Commit-Position: refs/heads/master@{#430253}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_container_view.mm View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
stkhapugin
ptal
4 years, 1 month ago (2016-10-25 16:09:29 UTC) #4
Eugene But (OOO till 7-30)
Thanks for a separate CL. https://codereview.chromium.org/2453473002/diff/1/ios/web/web_state/ui/crw_web_controller_container_view.mm File ios/web/web_state/ui/crw_web_controller_container_view.mm (right): https://codereview.chromium.org/2453473002/diff/1/ios/web/web_state/ui/crw_web_controller_container_view.mm#newcode155 ios/web/web_state/ui/crw_web_controller_container_view.mm:155: - (id<CRWWebControllerContainerViewDelegate>)delegate { nit: ...
4 years, 1 month ago (2016-10-25 18:11:12 UTC) #7
Eugene But (OOO till 7-30)
Could you please update CL description and explain *why* this change was made. lgtm https://codereview.chromium.org/2453473002/diff/1/ios/web/web_state/ui/crw_web_controller.mm ...
4 years, 1 month ago (2016-10-25 18:24:34 UTC) #8
stkhapugin
Comments
4 years, 1 month ago (2016-11-07 10:43:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453473002/40001
4 years, 1 month ago (2016-11-07 11:40:46 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-07 11:49:58 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 11:52:58 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f3eb56c71f307254488a00cbe09a7561149ed41
Cr-Commit-Position: refs/heads/master@{#430253}

Powered by Google App Engine
This is Rietveld 408576698